Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SH] make address null-safe #149

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[SH] make address null-safe #149

merged 2 commits into from
Jan 23, 2025

Conversation

cyroxx
Copy link
Collaborator

@cyroxx cyroxx commented Jan 23, 2025

The spider for Schleswig-Holstein ran into an error because of an empty house number.
This PR makes the address extraction more robust.

@cyroxx cyroxx requested review from k-nut and knutator2 January 23, 2025 18:56
@k-nut
Copy link
Member

k-nut commented Jan 23, 2025

Nice, I just noticed this morning that it had broken and made a note to take a look. Thank you for beating me to it :)

Co-authored-by: Knut Hühne <[email protected]>
@cyroxx cyroxx merged commit 45a4e88 into master Jan 23, 2025
3 checks passed
@cyroxx cyroxx deleted the fix/sh_make_address_null_safe branch January 23, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants