Update MD027/no-multiple-space-blockquote to handle multiple lines of…

… indented code inside a blockquote (fixes #1393).
DavidAnson · Oct 29, 2024 · 0eedda0 · 0eedda0
1 parent 368cb1b
commit 0eedda0
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 4 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -4680,9 +4680,15 @@ module.exports = {
   "tags": [ "blockquote", "whitespace", "indentation" ],
   "parser": "micromark",
   "function": function MD027(params, onError) {
+    const { tokens } = params.parsers.micromark;
     for (const token of filterByTypesCached([ "linePrefix" ])) {
-      const siblings = token.parent?.children || params.parsers.micromark.tokens;
-      if (siblings[siblings.indexOf(token) - 1]?.type === "blockQuotePrefix") {
+      const parent = token.parent;
+      const codeIndented = parent?.type === "codeIndented";
+      const siblings = parent?.children || tokens;
+      if (
+        !codeIndented &&
+        (siblings[siblings.indexOf(token) - 1]?.type === "blockQuotePrefix")
+      ) {
         const { startColumn, startLine, text } = token;
         const { length } = text;
         const line = params.lines[startLine - 1];

diff --git a/lib/md027.js b/lib/md027.js
@@ -13,9 +13,15 @@ module.exports = {
   "tags": [ "blockquote", "whitespace", "indentation" ],
   "parser": "micromark",
   "function": function MD027(params, onError) {
+    const { tokens } = params.parsers.micromark;
     for (const token of filterByTypesCached([ "linePrefix" ])) {
-      const siblings = token.parent?.children || params.parsers.micromark.tokens;
-      if (siblings[siblings.indexOf(token) - 1]?.type === "blockQuotePrefix") {
+      const parent = token.parent;
+      const codeIndented = parent?.type === "codeIndented";
+      const siblings = parent?.children || tokens;
+      if (
+        !codeIndented &&
+        (siblings[siblings.indexOf(token) - 1]?.type === "blockQuotePrefix")
+      ) {
         const { startColumn, startLine, text } = token;
         const { length } = text;
         const line = params.lines[startLine - 1];

diff --git a/test/blockquote_spaces.md b/test/blockquote_spaces.md
@@ -46,3 +46,17 @@ Test nothing in the blockquote:
 
 >  
 {MD027:-1}
+
+<!-- markdownlint-disable code-block-style -->
+
+> Blockquoted code blocks:
+>
+>     Code
+>     Code
+>      Code
+>
+> ```text
+> Code
+> Code
+>  Code
+> ```
diff --git a/test/snapshots/markdownlint-test-scenarios.js.md b/test/snapshots/markdownlint-test-scenarios.js.md
@@ -6825,6 +6825,20 @@ Generated by [AVA](https://avajs.dev).
       ␊
       > ␊
       {MD027:-1}␊
+      ␊
+      <!-- markdownlint-disable code-block-style -->␊
+      ␊
+      > Blockquoted code blocks:␊
+      >␊
+      >     Code␊
+      >     Code␊
+      >      Code␊
+      >␊
+      > \`\`\`text␊
+      > Code␊
+      > Code␊
+      >  Code␊
+      > \`\`\`␊
       `,
     }
 

diff --git a/test/snapshots/markdownlint-test-scenarios.js.snap b/test/snapshots/markdownlint-test-scenarios.js.snap