Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include standard headers to use bool and size_t #23

Merged

Conversation

dmitry-kabanov
Copy link
Contributor

Hi, I'd like to propose a small fix that fixing the compilation error about unknown type bool and removes linting warnings about size_t when hashmap_base.h is opened.

The first is an actual error, at least with Clang 14 on macOS. The warning about size_t does not lead to errors, as stddefs.h in hashmap.h is included, however, inside Neovim, linting with clang++ (and C++14 standard) leads to these warnings.

Copy link
Collaborator

@dleeds-cpi dleeds-cpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DavidLeeds DavidLeeds merged commit ebb7494 into DavidLeeds:master Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants