Skip to content

Commit

Permalink
Hotfix parameterization
Browse files Browse the repository at this point in the history
  • Loading branch information
mrzealot committed Jan 14, 2022
1 parent 488fba0 commit 47d15c0
Show file tree
Hide file tree
Showing 6 changed files with 60 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ergogen",
"version": "3.1.0",
"version": "3.1.1",
"description": "Ergonomic keyboard layout generator",
"author": "Bán Dénes <[email protected]>",
"license": "MIT",
Expand Down
1 change: 1 addition & 0 deletions src/ergogen.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const process = async (raw, debug=false, logger=()=>{}) => {
logger('Preprocessing input...')
config = prepare.unnest(config)
config = prepare.inherit(config)
config = prepare.parameterize(config)
const results = {}
if (debug) {
results.raw = raw
Expand Down
9 changes: 8 additions & 1 deletion src/prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ exports.inherit = config => traverse(config, config, [], (target, key, val, root
})

exports.parameterize = config => traverse(config, config, [], (target, key, val, root, breadcrumbs) => {

// we only care about objects
if (a.type(val)() !== 'object') {
target[key] = val
return
}

let params = val.$params
let args = val.$args

Expand Down Expand Up @@ -108,7 +115,7 @@ exports.parameterize = config => traverse(config, config, [], (target, key, val,
let str = JSON.stringify(val)
const zip = rows => rows[0].map((_, i) => rows.map(row => row[i]))
for (const [par, arg] of zip([params, args])) {
str = str.replace(new RegExp(`"${par}"`, 'g'), JSON.stringify(arg))
str = str.replace(new RegExp(`${par}`, 'g'), arg)
}
try {
val = JSON.parse(str)
Expand Down
30 changes: 30 additions & 0 deletions test/unit/interface.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,36 @@ describe('Interface', function() {
ergogen.process({points: {zones: {}}}, true, () => {}).should.be.rejectedWith('any points')
])
})

it('preprocessor', async function() {
return Promise.all([
// unnesting
ergogen.process({'points.zones.matrix': {}}).should.eventually.have.deep.property('canonical', {
points: {zones: {matrix: {}}}
}),
// inheritance
ergogen.process({
'points.zones.parent.key.a': 1,
'points.zones.child': {
'$extends': 'points.zones.parent',
'key.b': 2
}
}).should.eventually.have.deep.nested.property('canonical.points.zones.child.key', {
a: 1,
b: 2
}),
// parameterization
ergogen.process({
'points.zones.matrix.key': {
a: 'PAR',
$params: ['PAR'],
$args: [1]
}
}).should.eventually.have.deep.nested.property('canonical.points.zones.matrix.key', {
a: '1'
})
])
})

it('engine', async function() {
return Promise.all([
Expand Down
20 changes: 18 additions & 2 deletions test/unit/prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,23 @@ describe('Prepare', function() {
$args: [1]
}
}).decl.should.deep.equal({
a: 1
a: '1'
})

p.parameterize({
decl: {
normal_use: 'PAR1',
sub: {
nested_use: 'PAR2 * 2'
},
$params: ['PAR1', 'PAR2'],
$args: ['text', 14]
}
}).decl.should.deep.equal({
normal_use: 'text',
sub: {
nested_use: '14 * 2',
}
})

p.parameterize.bind(this, {
Expand All @@ -84,7 +100,7 @@ describe('Prepare', function() {
decl: {
a: 'PAR',
$params: ['PAR'],
$args: [undefined]
$args: ['in"jection']
}
}).should.throw('valid')
})
Expand Down

0 comments on commit 47d15c0

Please sign in to comment.