Skip to content

Commit

Permalink
add rpevious bench to function
Browse files Browse the repository at this point in the history
  • Loading branch information
DawidNiezgodka committed Oct 18, 2023
1 parent 44b367c commit 7a7341d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
6 changes: 3 additions & 3 deletions benchmark_results/curr.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"benchInfo": {
"executionTime": "18 m",
"executionTime": "138 m",
"parametrization": {
"ack": "3",
"ack": "1",
"read-in-ram": true
},
"otherInfo": "kafka, v2.3"
},
"results": [
{
"unit": "ms",
"value": 700,
"value": 701,
"name": "latency"
},
{
Expand Down
6 changes: 4 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/comment.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ module.exports.createCommentBodyForComparisonWithPrevBench = function (
lines.push("Watch out! You're comparing benchmarks with different names!")
}
// Call the function to generate bench_data text
const benchDataText =
module.exports.createBenchDataTextForCompWithPrev(currentBenchmark)
const benchDataText = module.exports.createBenchDataTextForCompWithPrev(
currentBenchmark,
previousBenchmark
)

// Append bench_data text to the lines array
lines.push(benchDataText)
Expand Down

1 comment on commit 7a7341d

@DawidNiezgodka
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark information

Current Benchmark Previous Benchmark
Execution time: 138 m Execution time: 18 m
Parametrization: Parametrization:
- ack: 1 - ack: 3
- read-in-ram: true - read-in-ram: true
Other Info: kafka, v2.3 Other Info: kafka, v2.3

Results

Metric name Current: 7a7341d Previous: 44b367c Condition Result
latency 701 ms 700 ms smaller 🟢
metric2 123 op/s 123 op/s bigger 🟢
metric3 456 % 456 % range 🟢

Please sign in to comment.