Skip to content

Commit

Permalink
add jump det comment v2
Browse files Browse the repository at this point in the history
  • Loading branch information
DawidNiezgodka committed Jan 22, 2024
1 parent f5e9b4c commit daaa9fe
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 18 deletions.
22 changes: 13 additions & 9 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 12 additions & 8 deletions src/comment.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,9 @@ module.exports.createBodyForComparisonWithJumpDeltas = function(evaluationResult
lines.push('', '', '', '', '')

lines.push(
`| Metric | Curr: ${currentBenchmark.commitInfo.id} | Prev: ${previousBenchmark.commitInfo.id} | Max. Jump | Was | Res | `
`| Metric | Curr: ${currentBenchmark.commitInfo.id} | Prev: ${previousBenchmark.commitInfo.id} | Max. Jump | Was | Res | `
)
lines.push('|-|-|-|-|-|-|-|')
lines.push('|-|-|-|-|-|-|')

const evaluationResults = evaluationResult.results.result
const evaluationParameters = evaluationResult.evalParameters
Expand All @@ -288,21 +288,25 @@ module.exports.createBodyForComparisonWithJumpDeltas = function(evaluationResult
const resultStatus = evaluationResults[i];
const metricName = evaluationParameters.metricNames[i];
const metricUnit = evaluationParameters.metricUnits[i];
const actualValue = parseFloat(evaluationParameters.is[i]).toFixed(2);

const currValue = currentBenchmark.results[i].value;
const prevValue = previousBenchmark.results[i].value;

const currPlusUnit = currValue + ' ' + metricUnit;
const prevPlusUnit = prevValue + ' ' + metricUnit;

const shouldBe = evaluationParameters.shouldBe[i];
const ratio = evaluationParameters.is[i];

const previousBenchRes = parseFloat(evaluationParameters.than[i]).toFixed(2);
const prevBenchValAndUnit = previousBenchRes + ' ' + metricUnit;

let line
let valueAndUnit = actualValue + ' ' + metricUnit


if (resultStatus === 'failed' || resultStatus === 'passed') {
let betterOrWorse = resultStatus === 'passed' ? '🟢' : '🔴'
line = `| \`${metricName}\` | \`${valueAndUnit}\` | \`${prevBenchValAndUnit}\` | ${shouldBe} | ${ratio} | ${betterOrWorse} |`
line = `| \`${metricName}\` | \`${currPlusUnit}\` | \`${prevPlusUnit}\` | ${shouldBe} | ${ratio} | ${betterOrWorse} |`
} else {
line = `| \`${metricName}\` | \'${valueAndUnit}\' | N/A | N/A | N/A | 🔘 |`
line = `| \`${metricName}\` | \'${currPlusUnit}\' | N/A | N/A | N/A | 🔘 |`
}

lines.push(line)
Expand Down
2 changes: 1 addition & 1 deletion src/evaluate.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ module.exports.evaluateWithJumpDetection = function (currentBenchmarkData, confi
shouldBe.push(threshold);

if (previousResult) {
const ratio = (currentValue / previousResult.value - 1) * 100;
const ratio = Math.abs((currentValue / previousResult.value - 1) * 100);
ratios.push(ratio.toFixed(2));
const isPassed = Math.abs(ratio) < threshold;
evaluationResults.push(isPassed ? 'passed' : 'failed');
Expand Down

0 comments on commit daaa9fe

Please sign in to comment.