fix(driver): Resolve Exception during PerformUpgrade using LogScriptOutput #577 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut #577 - Drop non supported frames. (Netstandard 1.3/Mono) - Replace System.Data.SQLite with Microsoft.Data.SqLite - Breaking change `Create` removed from TemporarySQLiteDatabase, it is now implicit
jafin
changed the title
# Conflicts: # src/Tests/ApprovalFiles/NoPublicApiChanges.Run.Net.verified.cs # src/Tests/SQLiteSupportTests.cs # src/Tests/SQLiteTableJournalTests.cs # src/dbup-sqlite/Helpers/InMemorySQLiteDatabase.cs # src/dbup-sqlite/Helpers/TemporarySQLiteDatabase.cs # src/dbup-sqlite/SQLiteScriptExecutor.cs # src/dbup-sqlite/dbup-sqlite.csproj
droyad
reviewed
Jul 29, 2024
Comment on lines
+26
to
+27
| Mode = SqliteOpenMode.Memory, | ||
| ConnectionString = "PRAGMA encoding='UTF-16'; PRAGMA journal_mode='MEMORY';" |
There was a problem hiding this comment.
I missed these in my conversion. Don't know enough about SQLite to judge whether this is good/bad, but keeping it.
|
Thanks @jafin. Finally got to the refactor+upgrade and looks like I did many of the same things you did. I've merge in the v6 beta branch. This is a good test, so worth including in the code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an update from 2001 to resolve #2
Checklist
Description
Breaking changes⚠️
Createremoved from TemporarySQLiteDatabase, it is now implicitNote: targeting main because that is all I can see.