-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce poetry #182
Merged
Merged
Introduce poetry #182
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
58054b2
poetry init
kenoss c6ec8f4
poetry add PyYAML numpy torch pytest
kenoss 46f2220
poetry add --dev kaggle-environments requests
kenoss 46631a1
chore: Use poetry in CI
kenoss b81390e
Update README.md
kenoss a0bdc03
style
kenoss deabf19
chore: Use poetry 1.1.5
kenoss 2ebef03
chore: pytest should be in dev dependencies
kenoss 256ba22
chore: Use pyproject.toml for pytest configuration
kenoss 8427e31
chore: poetry free
kenoss 77ebd43
comment
kenoss bf0c044
Merge remote-tracking branch 'origin/develop' into introduce-poetry
kenoss 5c16ed2
poetry add psutil
kenoss c95e16a
chore: Update requirements.txt
kenoss fe07141
style
kenoss f6878f9
chore: Add test with up-to-date dependencies
kenoss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,25 +6,53 @@ on: | |
push: | ||
|
||
jobs: | ||
pytest: | ||
name: Run pytest | ||
test: | ||
name: Test | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-latest, windows-latest] | ||
python-version: [3.7, 3.8, 3.9] | ||
poetry-version: [1.1.5] | ||
with-up-to-date-dependencies: [false, true] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
- uses: abatilo/[email protected] | ||
with: | ||
poetry-version: ${{ matrix.poetry-version }} | ||
- name: Remove the lockfile to install latest packages | ||
if: matrix.with-up-to-date-dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install -r requirements.txt | ||
pip install -r handyrl/envs/kaggle/requirements.txt | ||
rm poetry.lock | ||
- run: | | ||
poetry install | ||
- name: pytest | ||
run: | | ||
python -m pytest tests | ||
poetry run python -m pytest | ||
validate-requirements: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.9] | ||
poetry-version: [1.1.5] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- uses: abatilo/[email protected] | ||
with: | ||
poetry-version: ${{ matrix.poetry-version }} | ||
- run: | | ||
# If failed, do | ||
# $ poetry export --without-hashes -f requirements.txt --output requirements.txt | ||
# $ poetry export --without-hashes -f requirements.txt --output requirements-dev.txt --dev | ||
diff <(poetry export --without-hashes -f requirements.txt | grep -v '^Warning:') requirements.txt | ||
diff <(poetry export --without-hashes -f requirements.txt --dev | grep -v '^Warning:') requirements-dev.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, handyrl is not a library yet and intended to use with environments under
env/
. And, this is a framework of training. So we don't need to care about docker and additional dependencypoetry
.Additional option is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#182 (comment)
We provide requirements.txt until #183 .