smiplify email provider selection logic with early return

Decidable-AS · Feb 23, 2024 · 7a98ef7 · 7a98ef7
1 parent c768342
commit 7a98ef7
Showing 1 changed file with 31 additions and 44 deletions.
diff --git a/index.ts b/index.ts
@@ -5,68 +5,55 @@ import { sendEmail as sendEmailPostmark } from "./adapters/postmark";
 export function createClient(providers: Provider[]) {
 	return {
 		async sendEmail(email: SendEmailInput) {
-			let result;
 			for (const provider of providers) {
 				const providerType = provider.type;
 				try {
 					switch (providerType) {
-						case "custom":
-							{
-								const res = await provider.sendEmail(email);
-								if (res.error) {
-									throw new Error(res.error);
-								}
-								result = {
-									type: providerType,
-									index: providers.indexOf(provider),
-									custom: res,
-								};
+						case "custom": {
+							const res = await provider.sendEmail(email);
+							if (res.error) {
+								throw new Error(res.error);
 							}
-							break;
+							return {
+								type: providerType,
+								index: providers.indexOf(provider),
+								custom: res,
+							};
+						}
 
-						case "resend":
-							{
-								const res = await sendEmailResend(provider, email);
-								if (res.error) {
-									throw res.error;
-								}
-								result = {
-									type: providerType,
-									index: providers.indexOf(provider),
-									resend: res as any,
-								};
+						case "resend": {
+							const res = await sendEmailResend(provider, email);
+							if (res.error) {
+								throw res.error;
 							}
-							break;
+							return {
+								type: providerType,
+								index: providers.indexOf(provider),
+								resend: res as any,
+							};
+						}
 
-						case "postmark":
-							{
-								const res = await sendEmailPostmark(provider, email);
-								if (res.ErrorCode) {
-									throw new Error(res.Message);
-								}
-								result = {
-									type: providerType,
-									index: providers.indexOf(provider),
-									postmark: res,
-								};
+						case "postmark": {
+							const res = await sendEmailPostmark(provider, email);
+							if (res.ErrorCode) {
+								throw new Error(res.Message);
 							}
-							break;
+							return {
+								type: providerType,
+								index: providers.indexOf(provider),
+								postmark: res,
+							};
+						}
 
 						default:
 							providerType satisfies never;
 							throw new Error("Invalid provider type");
 					}
-					if (result) {
-						break;
-					}
 				} catch (error) {
 					console.error(error);
 				}
 			}
-			if (!result) {
-				throw new Error("No email provider available");
-			}
-			return result;
+			throw new Error("No email provider available");
 		},
 	};
 }