Migrating Quicktest to PyTest and adding dockerized self hosted runner #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkuegler requesting review |
taha-abdullah
changed the title
dkuegler
requested changes
Jul 30, 2024
dkuegler
reviewed
Jul 31, 2024
|
@dkuegler requesting review after suggested fixes |
dkuegler
requested changes
Aug 14, 2024
|
Please clean up/squash the git history a bit. |
taha-abdullah
force-pushed
the
pytest
branch
2 times, most recently
from
64b9c6c
to
876d767
Compare
dkuegler
requested changes
Aug 30, 2024
|
Please also apply changes from the reviews and clean up the git history. |
taha-abdullah
force-pushed
the
pytest
branch
3 times, most recently
from
19fa7f8
to
4be5147
Compare
taha-abdullah
force-pushed
the
pytest
branch
from
4be5147
to
3c40791
Compare
|
@dkuegler please review |
taha-abdullah
force-pushed
the
pytest
branch
2 times, most recently
from
c669fa8
to
8501c47
Compare
- added support for multiple test subjects and parameterization in all tests - reorganized file structure - separate stats files for each aseg and aparc+DKT - moving fixtures and common functions to common.py and conftest.py quicktest_runner.yaml: - removed check-output job - added THIS_RUN_DIR to seperate different runs
- documentation fixes in quicktest.yaml - docstring fixes in test_errors_in_logfiles.py - removed loop over assert in test_file_existence.py
taha-abdullah
force-pushed
the
pytest
branch
4 times, most recently
from
af9be34
to
6538b5a
Compare
|
@dkuegler please review again |
taha-abdullah
force-pushed
the
pytest
branch
from
6538b5a
to
402bcc6
Compare
taha-abdullah
force-pushed
the
pytest
branch
from
402bcc6
to
c00e2f4
Compare
… thus simplifying, and streamlining the workflow and improving execution time significantly. Adding Labelled output directories for each run Removing unnecessary import statements from pytest files Cleaning up code: - migrating from os.path.join to pathlib Path - changing str to Path - cleaning up comments and docstrings - ran ruff on code to fix code style
taha-abdullah
force-pushed
the
pytest
branch
from
c00e2f4
to
810a170
Compare
dkuegler
requested changes
Sep 17, 2024
taha-abdullah
force-pushed
the
pytest
branch
from
e8aff44
to
054ea58
Compare
dkuegler
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests for:
migrated tests from unittest to pytest framework
changed fastsurfer to run multiple subjects
added new workflow (quicktest_runner) to run on dockerized self-hosted runner