Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to shell scripts #553

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

dkuegler
Copy link
Member

@dkuegler dkuegler commented Aug 7, 2024

Add a checking for subjects_dir to run_fastsurfer.sh (whether subject_dir is set, is root, is writable)
Bump tqdm to 4.66 (has no effect on results)
add BATCH documentation (brun_fastsurfer.sh usage docs and TQDM_DISABLE=1 doc) Add --env TQDM_DISABLE=1 for slurm running to pollute the logs less Fix the parsing of subjects in brun_fastsurfer.sh
Clean up the parameter parsing and fix some minor Shellshock Warning in srun_fastsurfer.sh

@dkuegler
Copy link
Member Author

dkuegler commented Aug 7, 2024

This PR does not pass checks because sphinx 8 somehow treats importing of files different to sphinx 7. This needs to be debugged at some point, but we should just use sphinx 7 for now.

The limitation to sphinx 7 is implemented in #552, so this PR's checks should rerun and be merged after merging #552.

…_dir is set, is root, is writable)

Bump tqdm to 4.66 (has no effect on results)
add BATCH documentation (brun_fastsurfer.sh usage docs and TQDM_DISABLE=1 doc)
Add --env TQDM_DISABLE=1 for slurm running to pollute the logs less
Fix the parsing of subjects in brun_fastsurfer.sh
Clean up the parameter parsing and fix some minor Shellshock Warning in srun_fastsurfer.sh
@m-reuter m-reuter merged commit a51e625 into Deep-MI:dev Aug 7, 2024
2 checks passed
@dkuegler dkuegler deleted the fix/brun-args-no-tqdm branch August 7, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants