BUG: --allow_root does not work for segstats module in hypvinn. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because allow_root is always set to False, root is not compatible with computing stats for hypvinn. This changes root to True, which is suboptimal, but fine. This is only a check in segstats and it is also already checked in run_prediction before (so this is redundant).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
allow_rootis hard coded toFalsein hypvinn/utils/stats_utils.py, computing stats for hypvinn crashes Fastsurfer when running as root despite passing the flag--allow_root.This PR changes allow_root (hard coded) to True, which is suboptimal, but fine. This always satisfies the check in segstats (for hypvinn). But this check is also performed in hypvinn/run_prediction.py (so the check in segstats is redundant anyways).