Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code style via ruff #573

Merged
merged 20 commits into from
Sep 4, 2024
Merged

Add code style via ruff #573

merged 20 commits into from
Sep 4, 2024

Conversation

m-reuter
Copy link
Member

@m-reuter m-reuter commented Sep 3, 2024

This switches on our code-style workflow mainly to run Ruff and spellchecker. So this fixes ruff messages in all code (lots of changes, but mainly very minor stuff).

m-reuter and others added 4 commits September 4, 2024 09:28
Co-authored-by: David Kügler <[email protected]>
- revert changes to the docstring of main
- move replacement of strings into a decorator function
- fix indentation errors in doc

FastSurferCNN/checkpoint.py
- import Scheduler from torch instead of string-declaring (which does not work with pipe for Union)

FastSurferCNN/parser_defaults.py
- revert <TYPE> | None to Optional[<TYPE>]
- add # noqa: UP0007 to ignore this ruff rule
- add documentation for this
- remove fields import
- add Optional import
- revert parser == None removal
- reformat for number of characters per line
@m-reuter m-reuter merged commit ed10636 into dev Sep 4, 2024
3 checks passed
@m-reuter m-reuter deleted the ruff branch September 4, 2024 13:05
@m-reuter m-reuter mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants