Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance feature extraction #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adrianomartinelli
Copy link

Problem

The feature extraction methods do not accept arguments. Sometimes it would be nice if one could run the same registered feature extraction method with different arguments (like for fingerprints)

Solution

Add dedicated {node,edge,graph}_feature_kwargs to from_molecule and from_smiles and pass those to the the function call. Furthermore, let the already implemented feature extraction methods accept **kwargs.

Test suite has been updated to test this functionality.

@KiddoZhu KiddoZhu force-pushed the master branch 11 times, most recently from 7392070 to e73d2c9 Compare June 4, 2022 04:09
@adrianomartinelli
Copy link
Author

Hi @KiddoZhu ! What do you think about this extension?

Best,
Adriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant