[Ascend] fuj/acl-index #1332
Merged
[Ascend] fuj/acl-index #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingguo-st
requested review from
hellozmz,
zhangzefeng92 and
yangbofun
as code owners
jingguo-st
force-pushed
the
fuj/acl-index
branch
from
857c3e9
to
2c40285
Compare
NeosZhang
reviewed
Aug 9, 2024
impl/ascend/functions/index.cpp
Outdated
| result.push_back(t); | ||
| } else { | ||
| if (t.dtype() == diopi_dtype_uint8 || t.dtype() == diopi_dtype_bool) { | ||
| ASCEND_CHECK(t.dtype() == diopi_dtype_uint8, |
There was a problem hiding this comment.
这个assert的条件错了，应该是断言ASCEND_CHECK(t.dtype() != diopi_dtype_uint8,
yangbofun
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
impl index with aclnn for ascend
Description
Use cases (Optional)
BC-breaking (Optional)
Checklist
Before PR:
After PR: