Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(droplet): add DEVICEIMPL as imported library #1341

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

lljbash
Copy link
Contributor

@lljbash lljbash commented Aug 13, 2024

Motivation and Context

最近的更新中给 DEVICEIMPL target 增加了属性,但是 s2 的 build 之前写得很不好,没有这个 target,导致无法 config。

Description

加入一个 imported target。

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@lljbash lljbash added the bug Something isn't working label Aug 13, 2024
@lljbash lljbash self-assigned this Aug 13, 2024
@lljbash lljbash changed the title build: add DEVICEIMPL as imported library in droplet build(droplet): add DEVICEIMPL as imported library Aug 13, 2024
@lljbash lljbash requested a review from fandaoyi August 13, 2024 12:22
@yangbofun yangbofun merged commit 1149415 into DeepLink-org:main Aug 13, 2024
17 checks passed
@lljbash lljbash deleted the llj/fix-s2-build branch August 14, 2024 02:48
lljbash added a commit to DeepLink-org/deeplink.framework.dev that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants