Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ascend] fuj / fix-index-error-for-ascend #1353

Merged

Conversation

jingguo-st
Copy link
Contributor

@jingguo-st jingguo-st commented Sep 2, 2024

Motivation and Context

some bugs found in index implementation: use split to get the nonzero elements for bool type indices

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@yangbofun yangbofun merged commit 7b59b56 into DeepLink-org:main Sep 3, 2024
17 checks passed
@yangbofun yangbofun deleted the fuj/fix-index-select-error branch September 3, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants