Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRIDEDIT-893: make curvilinear grid indexing consistent #297

Merged
merged 33 commits into from
Feb 7, 2024
Merged

GRIDEDIT-893: make curvilinear grid indexing consistent #297

merged 33 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. NumM and NumN made private

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d728bb6 View commit details
    Browse the repository at this point in the history

  2. Fix method comments

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ae644ad View commit details
    Browse the repository at this point in the history

  3. Additional access methods

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9d82248 View commit details
    Browse the repository at this point in the history

  4. Using access methods for m,n indexing

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ff11ccf View commit details
    Browse the repository at this point in the history

  5. Use new methods to get row and column vectors

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    99a1acb View commit details
    Browse the repository at this point in the history

  6. Using access methods for m,n indexing (2) 

    some calls found after previous commit
    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c103df9 View commit details
    Browse the repository at this point in the history

  7. Renamed method to clarify that node validity is tested

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b38b616 View commit details
    Browse the repository at this point in the history

  8. Added access method for face mask

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    19761e9 View commit details
    Browse the repository at this point in the history

  9. Using numM, numN

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ffe1b08 View commit details
    Browse the repository at this point in the history

  10. Grid faces mask matrix made private

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e9b686d View commit details
    Browse the repository at this point in the history

  11. Added grid node type access method, storage matrix made private

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b27fc0e View commit details
    Browse the repository at this point in the history

  12. Gridindices matrix made private

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d6ec13d View commit details
    Browse the repository at this point in the history

  13. Use GetNodes() access method

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    273bee1 View commit details
    Browse the repository at this point in the history

  14. Using GetNode access method

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2b73525 View commit details
    Browse the repository at this point in the history

  15. Added asserts for the increasing number of rows/cols

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d7fac5b View commit details
    Browse the repository at this point in the history

  16. Use last row/column index consistently

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    799f951 View commit details
    Browse the repository at this point in the history

  17. Use matrix dimensions for NumM and NumN

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4c98e81 View commit details
    Browse the repository at this point in the history

  18. Use NumM and NumN methods for grid dimensions

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0cfc139 View commit details
    Browse the repository at this point in the history

  19. Use NumM and NumN methods for grid dimensions

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    dff3f54 View commit details
    Browse the repository at this point in the history

  20. Make gridnodes member private

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b8bd3f3 View commit details
    Browse the repository at this point in the history

  21. Using NumM and NumN for dimensions

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a6dc73e View commit details
    Browse the repository at this point in the history

  22. Adjusted documentation of NumN and NumM

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9729fcd View commit details
    Browse the repository at this point in the history

  23. Adjusted comment of GetNodes

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0a73429 View commit details
    Browse the repository at this point in the history

  24. Renamed and fixed documentation for getters of row/column vectors

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f0bbda8 View commit details
    Browse the repository at this point in the history

  25. Renamed parameters and updated documentation

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d2fb82d View commit details
    Browse the repository at this point in the history

  26. Made parameter comments consistent

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    59018dc View commit details
    Browse the repository at this point in the history

  27. Document row/column to m/n correspondence

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    de7c6a2 View commit details
    Browse the repository at this point in the history

  28. Documented behavior of SetFlatCopies and ConvertCurvilinearToNodesAnd… 

    …Edges
    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7e16ef7 View commit details
    Browse the repository at this point in the history

  29. Added node serialization test

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1e17f03 View commit details
    Browse the repository at this point in the history

  30. Added node serialization test with invalid node

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cc11b8e View commit details
    Browse the repository at this point in the history

  31. Added edge serialization test

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9f2581b View commit details
    Browse the repository at this point in the history

  32. Added edge serialization test with invalid node

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0fce458 View commit details
    Browse the repository at this point in the history

  33. Removed tests that always evaluate to true

    @andreasbuykx
    andreasbuykx committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fd3fb27 View commit details
    Browse the repository at this point in the history