Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages for invalid NodeID #1826

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Error messages for invalid NodeID #1826

merged 8 commits into from
Sep 19, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1824

@Jingru923 Jingru923 requested a review from visr September 19, 2024 09:44
@Jingru923 Jingru923 linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion for a bit more specific error message, with that it looks good to me.

core/src/parameter.jl Outdated Show resolved Hide resolved
core/src/parameter.jl Outdated Show resolved Hide resolved
core/test/validation_test.jl Outdated Show resolved Hide resolved
core/test/validation_test.jl Outdated Show resolved Hide resolved
Jingru923 and others added 4 commits September 19, 2024 13:31
core/test/validation_test.jl Outdated Show resolved Hide resolved
@visr visr merged commit 87f535f into main Sep 19, 2024
16 of 20 checks passed
@visr visr deleted the error-msg branch September 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give comprehensive error messages for idx<0 in core
2 participants