Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dutch waterways model #446

Merged
merged 32 commits into from
Aug 24, 2023
Merged

Dutch waterways model #446

merged 32 commits into from
Aug 24, 2023

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #428.

@SouthEndMusic SouthEndMusic marked this pull request as draft July 21, 2023 16:22
@SouthEndMusic SouthEndMusic mentioned this pull request Jul 27, 2023
Closed
@SouthEndMusic
Copy link
Collaborator Author

The model now runs but does not properly converge yet

@SouthEndMusic SouthEndMusic marked this pull request as ready for review August 21, 2023 13:25
@SouthEndMusic
Copy link
Collaborator Author

One thing to mention here is that the truth states U/D were removed from the docs (usage.qmd) but they are still in use (also as user input), so maybe they have to be brought back to the docs?

@visr visr mentioned this pull request Aug 22, 2023
Closed
visr
visr reviewed Aug 22, 2023
View reviewed changes
python/ribasim/ribasim/geometry/node.py Outdated Show resolved Hide resolved
python/ribasim/tests/test_model.py Outdated Show resolved Hide resolved
@visr visr merged commit 40acfa0 into main Aug 24, 2023
14 of 17 checks passed
@visr visr deleted the Dutch_waterways_model branch August 24, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrete Control tests based on realistic model
2 participants
@SouthEndMusic @visr