Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow condition on flow boundary #478

Merged
merged 13 commits into from
Aug 8, 2023
Merged

Flow condition on flow boundary #478

merged 13 commits into from
Aug 8, 2023

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #471.

@SouthEndMusic SouthEndMusic requested a review from visr August 4, 2023 08:23
@SouthEndMusic SouthEndMusic marked this pull request as draft August 4, 2023 08:23
@SouthEndMusic SouthEndMusic marked this pull request as ready for review August 7, 2023 13:55
visr
visr approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.
Since negative flow_rate is no longer supported, didn't you intend for FlowBoundary to only add water to the system? If so, I guess Basin going to FlowBoundary should be disallowed from neighbortypes?

@SouthEndMusic SouthEndMusic merged commit 305f335 into main Aug 8, 2023
17 checks passed
@SouthEndMusic SouthEndMusic deleted the flow_condition_on_flow_boundary branch August 8, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow condition only on interpolated flow boundary
2 participants
@SouthEndMusic @visr