Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pid control and sparsity #609

Closed
wants to merge 4 commits into from
Closed

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Sep 20, 2023

Fixes #482.

The above issue is quite outdated, but I picked it up because something was missing for the sparsity when using PID control. However, I have not been able to (re)produce the problem, so the current sparsity seems fine.

@SouthEndMusic SouthEndMusic marked this pull request as draft September 20, 2023 14:10
@SouthEndMusic
Copy link
Collaborator Author

As the problem this PR tries to solve cannot be (re)produced, I close this PR.

@visr visr deleted the pid_control_and_sparsity branch September 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for PID controlled pump
1 participant