Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support one way of raising exceptions for no data. #1036

Closed
Jaapel opened this issue Sep 2, 2024 · 0 comments · Fixed by #1055
Closed

Only support one way of raising exceptions for no data. #1036

Jaapel opened this issue Sep 2, 2024 · 0 comments · Fixed by #1055
Assignees
Labels
Enhancement New feature or request Needs refinement issue still needs refinement
Milestone

Comments

@Jaapel
Copy link
Contributor

Jaapel commented Sep 2, 2024

Kind of request

Changing existing functionality

Enhancement Description

Currently there are 2 implementations for checking for no data: NoDataStrategy and handle_error_method. We should refactor to use just one and keep it that way.

Use case

Maintainability

Additional Context

No response

@Jaapel Jaapel added Enhancement New feature or request Needs refinement issue still needs refinement labels Sep 2, 2024
@Jaapel Jaapel added this to the v1.0 beta milestone Sep 2, 2024
@savente93 savente93 linked a pull request Sep 23, 2024 that will close this issue
11 tasks
@savente93 savente93 modified the milestones: v1.0 beta, v1.0 Sep 23, 2024
@savente93 savente93 self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs refinement issue still needs refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants