Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ErrorHandlingMethod in favour of NoDataStrategy #1055

Merged
merged 7 commits into from
Sep 23, 2024
Merged

remove ErrorHandlingMethod in favour of NoDataStrategy #1055

merged 7 commits into from
Sep 23, 2024

Conversation

savente93
Copy link
Contributor

@savente93 savente93 commented Sep 23, 2024 •
edited
Loading

Issue addressed

Fixes #1036

Explanation

HandleNodataStrategy is much more widely used in the driver side, while ErrorHandlingMethod was only really really used for stac. Thefore we're deprecating the latter in favour of the former

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation
  • Updated changelog.rst

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been chagned
  • data/chagnelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@savente93 savente93 requested a review from Jaapel September 23, 2024 08:38
@savente93 savente93 linked an issue Sep 23, 2024 that may be closed by this pull request
Only support one way of raising exceptions for no data. #1036
Closed
@savente93 savente93 marked this pull request as ready for review September 23, 2024 08:53
Jaapel
Jaapel suggested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Jaapel Jaapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed a few tests, which do not only check the previous on_error behaviour, but also test the methods. Why is that?

tests/data_catalog/test_data_catalog.py Outdated Show resolved Hide resolved
tests/data_catalog/sources/test_geo_dataframe_source.py Outdated Show resolved Hide resolved
@savente93 savente93 requested a review from Jaapel September 23, 2024 12:14
@savente93 savente93 merged commit bb088c9 into v1 Sep 23, 2024
8 checks passed
@savente93 savente93 deleted the unify-error-handling branch September 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaapel Jaapel Jaapel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only support one way of raising exceptions for no data.
2 participants
@savente93 @Jaapel