Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use predicate arg in vector driver #1056

Merged
merged 1 commit into from
Sep 23, 2024
Merged

use predicate arg in vector driver #1056

merged 1 commit into from
Sep 23, 2024

Conversation

Jaapel
Copy link
Contributor

@Jaapel Jaapel commented Sep 23, 2024

Issue addressed

Fixes #983

Explanation

Predicate argument is still needed. I have added it in the geodataset_vector, GeoDatasetDriver. We can implement these for geodataframe drivers in the future

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with v1
  • Tests & pre-commit hooks pass
  • Updated documentation
  • Updated changelog.rst

@Jaapel Jaapel added the V1 label Sep 23, 2024
@Jaapel Jaapel requested a review from savente93 September 23, 2024 09:02
@Jaapel Jaapel self-assigned this Sep 23, 2024
savente93
savente93 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jaapel Jaapel merged commit 113a861 into v1 Sep 23, 2024
8 checks passed
@Jaapel Jaapel deleted the use_predicate_arg branch September 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savente93 savente93 savente93 approved these changes

Assignees

@Jaapel Jaapel

Labels
V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaapel @savente93