Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/unify not logged user messages #1619

Merged

Conversation

saeta-eth
Copy link
Collaborator

No description provided.

@saeta-eth saeta-eth requested a review from franciclo July 10, 2018 16:42
Copy link
Contributor

@franciclo franciclo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the consistency of the not logged state is good, but i find a bug, whenever i login and i get redirected to a topic there is an error in the console and the topic view is not fully loaded.
I tried it with topics where i already voted, with every kind of action, can you check that out before merging?

@saeta-eth
Copy link
Collaborator Author

I can't reproduce the issue mentioned above. After logging successfully, I always was redirected to the previous topic.

To make this changes I have followed these rules:

  • If the users are not logged and topic is not close, they can't vote the topic. (Login required)
  • If the users are voted and topic is not close, they can change their votes. (Login required).
  • If the users are logged and topic is not close, they can vote .
  • If topic is close, the users (logged or not) can see the results.

@franciclo franciclo changed the base branch from master to development July 16, 2018 18:46
@franciclo franciclo merged commit 2440324 into DemocracyOS:development Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants