Custom particles #32
Open
Custom particles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested on Discord.
Adds custom particles - not going to go over every feature, but overall:
ParticleTag& it's relevant featuresparticlecommand expansions for thisParticles don't actually have any sort of ID, so mixined in a
UUID+ map to store particles by their UUID so thatParticleTagcan base itself on something.Since this is received from the server & the client can leave/join as many servers as it wants, had to build in some ✨dynamic registry modification✨.
Overall I believe it's relatively safe, as it's purely client-side, properly removes it from all of the registry's maps, and re-freezes it later, but let me know what do you think.
Tried building around existing particle texture features & slightly hack in the textures list you'd usually specify in a json file, mostly to try and stay as close to vanilla as possible to avoid something changing and breaking everything in the future - let me know if you think that's not worth it and we should just have our own texture features though.