Attach + EntityTag beginnings #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
reviewed
Oct 19, 2022
| } | ||
|
|
||
| public static void autoExecute(ScriptEntry scriptEntry, | ||
| @ArgLinear @ArgName("entities") List<EntityTag> attachingEntities, |
There was a problem hiding this comment.
List isn't a supported parameter type, should use ListTag & ListTag#filter
tal5
reviewed
Oct 19, 2022
| return null; | ||
| } | ||
| if (string.startsWith("e@")) { | ||
| return new EntityTag(UUID.fromString(string.substring(2))); |
There was a problem hiding this comment.
Should check if it starts with e@ and substring before doing the UUID conversion, as just a UUID is valid as well
tal5
reviewed
Oct 19, 2022
| } | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Also missing getObjectAttribute implementation
This reverts commit 4d44a6c.
tal5
added a commit
that referenced
this pull request
Jan 15, 2023
tal5
added a commit
that referenced
this pull request
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is quite funny