Added Strays to the should_burn property
#2638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heypr
commented
Aug 2, 2024
heypr
commented
- Very small PR.
mcmonkey4eva
reviewed
Aug 2, 2024
| // --> | ||
|
|
||
| public static boolean describes(EntityTag entity) { | ||
| return entity.getBukkitEntity() instanceof Zombie | ||
| || entity.getBukkitEntity() instanceof Skeleton | ||
| || entity.getBukkitEntity() instanceof Stray |
There was a problem hiding this comment.
Should this just be AbstractSkeleton (covering both Skeleton and Stray), which is the interface that the method is on anyway?
mcmonkey4eva
approved these changes
Aug 3, 2024
|
LGTM, but should test on 1.17 before merge - looks like the methods where a bit different back then so just make sure it all works |
|
Did you perform the testing Aya requested yet? |
Yes, it functions the same on 1.17. |
Are you sure? from some testing it seems to throw a NoSuchMethod for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.