Determination format modernization Part.2 #2689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,9 @@ public class RedstoneScriptEvent extends BukkitScriptEvent implements Listener { | |||
|
|
|||
| public RedstoneScriptEvent() { | |||
| registerCouldMatcher("redstone recalculated"); | |||
| this.<RedstoneScriptEvent, ElementTag>registerDetermination(null, ElementTag.class, (evt, context, current) -> { | |||
| evt.event.setNewCurrent(current.asInt()); | |||
There was a problem hiding this comment.
these rewrites are removing the error checks that the prior impl had
| return switch (name) { | ||
| case "location" -> location; | ||
| case "item" -> item; | ||
| case "recipe_id" -> new ElementTag(Utilities.namespacedKeyToString(event.getRecipe().getKey()), true); |
There was a problem hiding this comment.
this is a functionality change
|
Updated |
| @@ -44,6 +45,11 @@ public class FurnaceStartsSmeltingScriptEvent extends BukkitScriptEvent implemen | |||
|
|
|||
| public FurnaceStartsSmeltingScriptEvent() { | |||
| registerCouldMatcher("furnace starts smelting <item>"); | |||
| this.<FurnaceStartsSmeltingScriptEvent, DurationTag>registerDetermination(null, DurationTag.class, (evt, context, time) -> { | |||
| if (time.asElement().isInt()) { | |||
There was a problem hiding this comment.
this still has no error handling that was previously available. Go test a bad determination on an old build vs your version and compare the results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the determination format for the following ScriptEvents :
FurnaceStartsSmeltingScriptEventRedstoneScriptEventEntityHealsScriptEventPlayerCraftsItemScriptEventPlayerItemTakesDamageScriptEvent