Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command line option: -display #657

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

sebholt
Copy link
Contributor

@sebholt sebholt commented Dec 17, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This introduces a new command line option -display that lets the user select the display on which the game should run on.
It is useful in multi-monitor setups where the game now can be run on any of the given monitors.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

The new command line option -display lets the user select the display on
which Descent 3 should be displayed.

This is useful in multi-monitor setups where the game now can be run on any of
the given monitors.
@sebholt
Copy link
Contributor Author

sebholt commented Dec 17, 2024

For reference, I followed this tutorial about multi monitor support in SDL2.

I've been motivated for this patch by the fact that my good/gaming monitor isn't the SDL default monitor and I always have to switch the monitor manually after starting the game.

@Lgt2x Lgt2x self-assigned this Dec 18, 2024
@Lgt2x
Copy link
Member

Lgt2x commented Dec 20, 2024

Hey, thanks for the contribution! the feature works as intended on Windows, it's a good improvement. I could not make it work on Linux, but that's possibly due to my peculiar monitor setup, or a bug in SDL2 upstream.

@Lgt2x Lgt2x merged commit 4ff0665 into DescentDevelopers:main Dec 20, 2024
12 checks passed
@sebholt sebholt deleted the display branch December 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants