Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export inventoryitem lite table type #69

Merged
merged 1 commit into from
Oct 26, 2023
Merged

export inventoryitem lite table type #69

merged 1 commit into from
Oct 26, 2023

Conversation

nev-r
Copy link
Member

@nev-r nev-r commented Oct 26, 2023

undocumented officially but this has been incredibly stable for years, and is technically typed this way somewhere deep in bnet's source ts files

@nev-r nev-r requested a review from bhollis October 26, 2023 08:28
@bhollis
Copy link
Contributor

bhollis commented Oct 26, 2023

Great! I was hoping to use this sometime, having the type will help.

I'm a touch nervous about using Omit rather than Pick, but it's a toss up whether we expect new properties to show up on this version or not.

@nev-r nev-r merged commit 8eb59e2 into master Oct 26, 2023
1 check passed
@nev-r nev-r deleted the inv-item-lite branch October 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants