Grahamc/determinate argument #123
Conversation
| plausibleDeterminateOptions.push("--entrypoint"); | ||
| plausibleDeterminateOptions.push("/usr/local/bin/determinate-nixd"); | ||
| plausibleDeterminateArguments.push("daemon"); |
There was a problem hiding this comment.
Hm, consider, do we want to update the default entrypoint for the image? I could see arguments both ways.
There was a problem hiding this comment.
It is kind of a crapshoot. Like maybe we want to just drop the entrypoint from the dockerfile?
I kind of feel like just not touching it, since we'd have to recommit the .tar.gz of the images. But we could :)
There was a problem hiding this comment.
Not sure what the "recommit the tar.gz" means, presumably it's just another nix build artifact? I guess you're meaning rev wherever we publish the container / IDS?
I am not worried about it, just wanted to mention. Dropping seems good/fine too. Whenever.
There was a problem hiding this comment.
Unfortunately since it needs to be available before Nix can run, it is literally checked in: https://github.com/DeterminateSystems/nix-installer-action/tree/main/docker-shim
Description
Closes #114.
Checklist