Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes after testing the modules #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

noemif
Copy link

@noemif noemif commented Mar 7, 2018

Fixes:

  • Module 1: missing assets when customising the static site
  • Module 2: SharedParentStack cloudformation parameter instructions missing from 2.2.4
  • Module 2: There is already an existing pipeline, need to create a new one
  • General: typos/grammar fixes

Other comments (things I couldn't fix in code):

Module 1:

  • There was no devops_girls keypair in account 214953911892
  • The "Edit Amazon EC2 configuration" step is easily missed, and that leads to a lot of pain later on. Need to highlight that step.

Module 2:

  • Snapshot 3-2-2-6 missing the SharedParentStack cloudformation parameter
  • Also, snapshot 3-2-2-6 shows an IAM role (not mentioned in the instructions)
  • Section 2.2.18 and snapshot 3-2-2-13 say that simple-app should display a "DevOps Girls" webpage, but I only got the default Apache "It Works" page.
  • The CodeBuild project VPC settings are unclear, my build kept failing and I'm not sure if it's related
  • I think the path for index.html in Dockerfile should be ./webpage/index.html, not ./index.html, but I couldn't get the build to work to test this.

General feedback on the course structure:

  • It's quite ambitious ! Unlike the previous bootcamp, at no point do attendees get to deploy a simple app manually on an EC2 instance, in the console, to get a feel for what is actually happening behind the scenes. We need to monitor attendees carefully to see if this is the way to introduce CD/CI to a crowd of potentially non-coders.

  • That said, thumbs up for using CodeStar/CodeCommit/CodePipeline as an AWS-integrated way of doing CD/CI, which we DO need to show.

I'll do my best to test module 3 before COB today...

Cheers,
Noemi

@noemif
Copy link
Author

noemif commented Mar 7, 2018

Hiya ! not sure who's monitoring this repo, so I'm just going to rudely ping all existing contributors:

@ramps41 @shivaman @verofa

Also I think some of my comments fixes have already been integrated this morning, sorry for the redundancy !

Looking forward to seeing you all on Saturday,
Noemi

@shivaman shivaman requested a review from mabbas1 March 8, 2018 00:41
@noemif
Copy link
Author

noemif commented Mar 8, 2018

Added a few more fixes after running module 3.

Mainly minor typos and grammar things, that module was a lot smoother than ECS :-)

Other more significant changes:

  • S3 upload step: explain where to get the files from (I don't think we clone the bootcamp repo earlier)
  • S3 upload step: cater for ppl without the AWS CLI (do we cover installation at any point ?)
  • Deployment: add instruction to reduce timout

ping @shivaman :-)

@noemif noemif changed the title Various changes after testing modules 1 and 2 Various changes after testing the modules Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants