Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOMEPAGE] fix: link labels for A11y #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marie-ototoi
Copy link

Problems:

  • all the links were labeled 'view results' or 'preview questions' => add the name of the survey + year
  • one link was double, with an empty label => hide it from screen readers

Before

Screenshot 2023-09-09 at 21 32 52

After

Screenshot 2023-09-10 at 13 41 46

@netlify
Copy link

netlify bot commented Sep 10, 2023

👷 Deploy request for tokyodev2022 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 97d1804

@netlify
Copy link

netlify bot commented Sep 10, 2023

👷 Deploy request for stateofjs2022 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 97d1804

@netlify
Copy link

netlify bot commented Sep 10, 2023

👷 Deploy request for css2023 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 97d1804

@vercel
Copy link

vercel bot commented Sep 10, 2023

@marie-ototoi is attempting to deploy a commit to the Devographics Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for state-of-graphql failed.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/64fdaf521bbd520008dba412

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for devographics-static failed.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/64fdaf527fde590008d40e0a

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for stateofjs failed.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/64fdaf52697036000861a154

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for stateofcss failed.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/64fdaf52b45c790008567306

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/64fdaf52e14aa50008d16eda

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for graphiql-devographics canceled.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/64fdaf528c128a0008cd27e2

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for devographics-graphiql2 canceled.

Name Link
🔨 Latest commit 97d1804
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql2/deploys/64fdaf526da6ec000875dc12

@marie-ototoi marie-ototoi marked this pull request as draft September 10, 2023 11:59
@marie-ototoi marie-ototoi marked this pull request as ready for review September 30, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant