Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): the initial 401 error is shown when it should not #1102

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix(webapp): the initial 401 error is shown when it should not #1102

merged 2 commits into from
Nov 11, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Nov 11, 2024 •
edited by CBenoit
Loading

Issue: DGW-226

@github-actions GitHub Actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

irvingoujAtDevolution
irvingoujAtDevolution commented Nov 11, 2024
View reviewed changes
webapp/src/client/app/modules/login/login.component.ts
@@ -77,7 +78,7 @@ export class LoginComponent extends BaseComponent implements OnInit {
}

private handleAutoLoginError(error): Observable<boolean> {
if (error.status && error.status !== '401') {
if (error?.status !== 401) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an integer instead of a string

rxjs catch error does not infer the type of the error

CBenoit
CBenoit approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@CBenoit CBenoit changed the title fix(webapp):fix auto login displayes error on 401 fix(webapp): the initial 401 error is shown when it should not Nov 11, 2024
@CBenoit CBenoit added the release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) label Nov 11, 2024
@github-actions GitHub Actions
Copy link

Maintainer action requested

Author requested a new release to be cut.

cc @CBenoit

@CBenoit CBenoit enabled auto-merge (squash) November 11, 2024 23:08
@CBenoit CBenoit merged commit b54a666 into master Nov 11, 2024
31 checks passed
@CBenoit CBenoit deleted the DGW-226-web-app-the-initial-401-error-is-shown-it-should-not branch November 11, 2024 23:23
@github-actions github-actions bot removed the release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

@kristahouse kristahouse Awaiting requested review from kristahouse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @CBenoit