fix(jetsocat): preemptively install crypto provider on start #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is typically not required because we only enable the ring backend, which is then automatically installed by rustls when `ClientConfig::builder` is called later down the road. However, it may be the case that during development the aws-lc-rs feature of rustls is enabled (especially when building the whole workspace at once), causing rustls to crash the process requesting to install a default crypto provider. To smoothen the developer experience, we attempt to install the ring crypto provider just before executing the command action. Our CI is already ensuring that we are not shipping both crypto backends by mistake. Changelog: ignore
CBenoit
force-pushed
the
fix/jetsocat-install-crypto-provider
branch
from
da68b6f
to
205e672
Compare
pacmancoder
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is typically not required because we only enable the ring backend, which is then automatically installed by rustls when
ClientConfig::builderis called later down the road. However, it may be the case that during development the aws-lc-rs feature of rustls is enabled (especially when building the whole workspace at once), causing rustls to crash the process requesting to install a default crypto provider.To smoothen the developer experience, we attempt to install the ring crypto provider just before executing the command action. Our CI is already ensuring that we are not shipping both crypto backends by mistake.
Changelog: ignore