Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): session toolbar loading issues #1106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kristahouse
Copy link
Contributor

Issue: DGW-230

Resolved Style Loading Delay in Session Component by Leveraging Existing Toolbar Component

Addressed an issue where .scss styles were not loading immediately for the ARD session component when it was loaded dynamically.

Utilized Existing Session Toolbar Component:
I used the session toolbar component, which was already implemented for the terminal based components (SSH & Telnet). I also updated all the other windows based components (RDP & VNC) as they all were at risk of the UI missing it's styles during a loading delay.

Reasoning:
The toolbar component independently manages its styles, avoiding any delay caused by asynchronous tasks in the parent session component. Leveraging this component for style loading eliminates the need for further adjustments to achieve consistent, immediate style rendering.

Testing and Validation:
Verified that styles in the toolbar component load immediately when the session component initializes dynamically.
Confirmed that there are no regressions in other components utilizing the toolbar.

Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBenoit CBenoit added the release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) label Nov 14, 2024
@CBenoit
Copy link
Member

CBenoit commented Nov 14, 2024

This is looking good to me too! You need to resolve the conflicts and ensure the CI is green before we can merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)
Development

Successfully merging this pull request may close these issues.

3 participants