fix(webapp): session toolbar loading issues #1106
Open
+1,839
−2,134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: DGW-230
Resolved Style Loading Delay in Session Component by Leveraging Existing Toolbar Component
Addressed an issue where .scss styles were not loading immediately for the ARD session component when it was loaded dynamically.
Utilized Existing Session Toolbar Component:
I used the session toolbar component, which was already implemented for the terminal based components (SSH & Telnet). I also updated all the other windows based components (RDP & VNC) as they all were at risk of the UI missing it's styles during a loading delay.
Reasoning:
The toolbar component independently manages its styles, avoiding any delay caused by asynchronous tasks in the parent session component. Leveraging this component for style loading eliminates the need for further adjustments to achieve consistent, immediate style rendering.
Testing and Validation:
Verified that styles in the toolbar component load immediately when the session component initializes dynamically.
Confirmed that there are no regressions in other components utilizing the toolbar.