Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom date range handling, theme support, input validation, and dynamic SVG generation for year progress calculation. #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aryanadla
Copy link

Implemented support for a custom date range using query parameters (startDate and endDate), allowing flexible progress calculation.
Added a theme option (light or dark mode) for customizing the colors of the progress bar.
Dynamic SVG generation to display real-time progress with proper date validation and clamped percentage values (0-100%).

image

…d dynamic SVG generation for year progress calculation.
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
year-in-progress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 7:07am

Copy link
Owner

@DhanushNehru DhanushNehru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts @aryanadla

Copy link
Collaborator

@hasan-py hasan-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! However, the feature has an issue. Please fix the issue and record a screen video to show that everything is working properly.

Screencast.from.2024-10-10.16-37-22.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants