Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.2 #12

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Version 0.2 #12

wants to merge 18 commits into from

Conversation

XedinUnknown
Copy link
Member

  • Fixed exception factories;
  • Compatible with StringableInterface;
  • Added parameter-less constructor;
  • Documentation fixes;
  • Fixed broken build config.

@XedinUnknown
Added next version entry to changelog
4901521
@XedinUnknown
Now suggesting dhii/stringable-interface
af98308 
Dependencies updated
@XedinUnknown
Added parameter doc
a1ee573 
Addresses #3.
@XedinUnknown
Travis will now use Precise distro
3065abe 
Fixes #5.
@XedinUnknown
Merge pull request #6 from Dhii/fix/5-travis-fails-to-build-legacy-ph…
5ab1b12 
…p-version

Travis Now Builds Legacy PHP Versions
@XedinUnknown
Merge branch 'develop' into fix/3-missing-parameter-doc
2825b0e
@XedinUnknown
Merge pull request #4 from Dhii/fix/3-missing-parameter-doc
634f547 
Added parameter doc
@XedinUnknown
Exception factories no longer accept a translator
97cdb59 
They are responsible for deducing the translator instance internally.
This fixes #7.
@XedinUnknown
Refactoring Exception dependencies
26818f1
@XedinUnknown
Exception factories now accept stringables as well as strings
4fc1aec
@XedinUnknown
Merge pull request #8 from Dhii/fix/7-exception-factories-break-tests…
3327c42 
…-and-soc

Exception Factories No Longer Break SoC
@XedinUnknown
Code standards fixed
b050cf5
@XedinUnknown
Added parameter-less constructor
182423f 
This fixes #2.
@XedinUnknown
Merge pull request #11 from Dhii/task/2-add-parameterless-constructor
0d11f7e 
Added Parameterless Constructor
@XedinUnknown XedinUnknown added this to the v0.2 milestone Aug 14, 2017
@XedinUnknown XedinUnknown self-assigned this Aug 14, 2017
mecha
mecha approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@mecha mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - albeit the lack of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mecha mecha mecha approved these changes

Assignees

@XedinUnknown XedinUnknown

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@XedinUnknown @mecha