This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Replace clock.png with clock.svg #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We see the same problem. It would be good to have this PR landed so that we can pick it up in the next version of the plugin. |
|
@patbos Can you please help review and merge this PR 🙏 ? |
owengo
referenced
this pull request
in jenkinsci/promoted-builds-plugin
Aug 20, 2024
… build history panel (#187) * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon --------- Co-authored-by: Mark Waite <[email protected]> Co-authored-by: Alexander Brandes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon for
Build nowis broken.I believe it is because Jenkins core has moved from pngs to svgs. More info here. This PR is the easiest fix for the same. Unfortunately I'm unable to build the plugin locally since it throws lot of maven plugin errors.
But, I was able to verify the fix by changing the local cache in Jenkins home.