Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1540: Remove references to summary pages/DB #860

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Nov 13, 2024

JIRA ticket: TICKET-1540

Summary:

Since the summary page was moved to a new and much improved codebase, it would be optimal to remove "dead" bits of code in SynchWeb that could cause confusion.

Improvements to components used elsewhere (such as comboboxes) were retained.

Changes:

  • Remove references to summary pages/DB in the code

To test:

@gfrn gfrn added javascript Pull requests that update Javascript code improvement php Pull requests that update PHP code labels Nov 13, 2024
@gfrn gfrn requested review from ndg63276 and NKatti2011 November 13, 2024 10:11
@gfrn gfrn self-assigned this Nov 13, 2024
Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn added the Configuration Change Pull requests which necessitate changes to SynchWeb configuration label Dec 10, 2024
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R1.1 January 13, 2025 11:31
@ndg63276 ndg63276 merged commit 060440a into pre-release/2025-R1.1 Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Change Pull requests which necessitate changes to SynchWeb configuration improvement javascript Pull requests that update Javascript code php Pull requests that update PHP code Ready to Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants