Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1570: Remove unused app file #874

Merged
merged 8 commits into from
Jan 28, 2025
Merged

LIMS-1570: Remove unused app file #874

merged 8 commits into from
Jan 28, 2025

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Dec 3, 2024

JIRA ticket: LIMS-1570

Summary:

Since the app file is not being used, and it features some unmaintained code, I figured it would be best to remove it.

Alongside it, a few unused libraries are also being removed.

Changes:

  • Remove unused dependencies
  • Remove dead app.js file and related files (superseded by Vue views)

To test:

  • Go to any page, ensure the sidebar still displays all expected links
  • Log in, ensure the log in page still works
  • Ensure the navbar still has all expected icons
    image

@gfrn gfrn added javascript Pull requests that update Javascript code improvement labels Dec 3, 2024
@gfrn gfrn changed the title [LIMS-1570] Remove unused app file LIMS-1570: Remove unused app file Dec 3, 2024
@ndg63276 ndg63276 self-requested a review January 24, 2025 11:59
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R1.2 January 28, 2025 09:48
@ndg63276 ndg63276 merged commit f4393fb into pre-release/2025-R1.2 Jan 28, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvements/lims-1570/remove-unused-app-file branch January 28, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndg63276 ndg63276 ndg63276 approved these changes

Assignees
No one assigned
Labels
improvement javascript Pull requests that update Javascript code Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfrn @ndg63276