Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass visit id when starting task #832

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Pass visit id when starting task #832

wants to merge 5 commits into from

Conversation

DiamondJoseph
Copy link
Contributor

Fixes #793

This does all of the grunt work necessary to get to a point where the instrument_session can be checked with the authentication information passed with the request to be checked to ensure the user is permitted to make their request.

Additional tasks coming off of this one and possible to be merged into this PR before it is merged in turn into main:

  • Allow user to select a visit when they log in
  • Cache the above visit if it is selected and pass it with every request to prevent having to be explicit
  • Checking authentication information and instrument_session to ensure user is authorized to make request
  • Using the instrument_session as part of the call to the PathProvider (see WIP numtracker integration #828 et al.)

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (bec48e6) to head (d6ab2ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   93.46%   93.45%   -0.01%     
==========================================
  Files          38       38              
  Lines        2112     2110       -2     
==========================================
- Hits         1974     1972       -2     
  Misses        138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass visit ID to blueapi where appropriate
1 participant