Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameters in distortion correction memory hook test #511

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update parameters in distortion correction memory hook test #511

merged 2 commits into from
Oct 24, 2024

Conversation

yousefmoazzam
Copy link
Collaborator

@yousefmoazzam yousefmoazzam commented Oct 23, 2024 •
edited by dkazanc
Loading

Fixes #510

Note that for the distortion correction memory hook test to pass on CI, this depends on a new release of httomolibgpu being made that contains the changes in DiamondLightSource/httomolibgpu#161.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@dkazanc dkazanc merged commit 2a56f55 into main Oct 24, 2024
6 of 7 checks passed
@dkazanc dkazanc deleted the issue-510 branch October 24, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update distortion correction memory hook test when httomolibgpu release containing parameter change is made
2 participants
@yousefmoazzam @dkazanc