removing autoinsertion of rescale_to_int for sweep runs #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
As it is stated in the issue #520 the auto-insertion of
rescale_to_int
in sweep runs where Paganin and reconstruction involved makes the reconstruction invalid as the input data for FBP is converted to integer type. This has been resolved by removing auto-insertion ofrescale_to_int
but enabling a conversion of floating point data in the image saver as oppose to just break previously when the data type is not uint8/16/32. This change shouldn't have any effect on the normal runner when the auto-insertion of scaling is not performed. However, when the user doesn't scale the data before the image saver the run will not fail, but the data won't be scaled uniformly.It is worth to note that when the users would like to save the rescaled projections themselves into images, the data will be rescaled into uint making processing after invalid. So, essentially we might want to restrict the number of
rescale_to_int
usages present in the pipeline (1 is the limit).Checklist