Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling begin, mid, end preview keywords #531

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Enabling begin, mid, end preview keywords #531

merged 7 commits into from
Dec 11, 2024

Conversation

dkazanc
Copy link
Collaborator

@dkazanc dkazanc commented Dec 4, 2024

  • adds begin, mid, end keywords to be used with start, stop parameters in preview.
  • adds start_offset and stop_offset to be used together with the keywords
  • adds tests for keywords and offsets as well as a pipeline where preview is used

Sorry for a couple irrelevant fixes, as they were needed for tests to pass.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@dkazanc dkazanc requested a review from yousefmoazzam December 4, 2024 22:14
tests/test_preview.py Outdated Show resolved Hide resolved
tests/test_preview.py Outdated Show resolved Hide resolved
tests/test_preview.py Outdated Show resolved Hide resolved
tests/test_preview.py Outdated Show resolved Hide resolved
httomo/transform_loader_params.py Show resolved Hide resolved
httomo/transform_loader_params.py Show resolved Hide resolved
Copy link
Collaborator

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

One last thing I might ask of for you (though I'm happy to do it if you're busy): the feature is modifying parse_preview(), which is in transform_loader_params.py, so I think the tests should go in test_transform_loader_params.py.

Could the new tests you've added be moved form test_preview.py to test_transform_loader_params.py please?

There's a few small things regarding types that I'm happy to do myself after that's been done.

@dkazanc dkazanc merged commit ebd18a6 into main Dec 11, 2024
6 checks passed
@dkazanc dkazanc deleted the preview_keywords branch December 11, 2024 11:32
yousefmoazzam added a commit to DiamondLightSource/httomo-backends that referenced this pull request Dec 11, 2024
Reflects change to raven filter memory estimator in
DiamondLightSource/httomo#531.
yousefmoazzam added a commit to DiamondLightSource/httomo-backends that referenced this pull request Dec 11, 2024
Reflects the change made to the list of CuFFT versions in
DiamondLightSource/httomo#531.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants