-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling begin, mid, end preview keywords #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
One last thing I might ask of for you (though I'm happy to do it if you're busy): the feature is modifying parse_preview()
, which is in transform_loader_params.py
, so I think the tests should go in test_transform_loader_params.py
.
Could the new tests you've added be moved form test_preview.py
to test_transform_loader_params.py
please?
There's a few small things regarding types that I'm happy to do myself after that's been done.
Reflects change to raven filter memory estimator in DiamondLightSource/httomo#531.
Reflects the change made to the list of CuFFT versions in DiamondLightSource/httomo#531.
Sorry for a couple irrelevant fixes, as they were needed for tests to pass.
Checklist