Remove backends information and get it from httomo-backends instead
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousefmoazzam
force-pushed
the
separate-backends
branch
from
456bc40 to
bdb5e0c
Compare
This removes the need to patch the `import_module()` call (which is now being done outside of `httomo`, in `httomo-backends`).
yousefmoazzam
force-pushed
the
separate-backends
branch
from
bdb5e0c to
d4959b8
Compare
yousefmoazzam
added a commit
to DiamondLightSource/httomo-backends
that referenced
this pull request
Jan 10, 2025
Some notes on this may be useful: - It was found that specifying `astra-toolbox` as a conda dependency in addition to `cupy` was able to make the GPU detectable in the CUDA container used in the IRIS CI job. However, the first job was sometimes such that the GPU wasn't detected and needed to be rerun, but then the second job would have the GPU be detected, for some reason. - Specifying all required packages as conda dependencies somehow got rid of the need to rerun the job, where the first job seemingly was consistent in having the GPU be detected. The reason(s) for this behaviour are unknown, but this may be a good enough workaround to enable `httomo` in the following PR to install and use `httomo-backends` without issues in the IRIS CI: DiamondLightSource/httomo#532.
yousefmoazzam
force-pushed
the
separate-backends
branch
from
bd5a2cb to
adde0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
This PR should be merged after DiamondLightSource/httomo-backends#6 has been merged and a new release of
httomo-backendshas been made. This is because that PR provides changes tohttomo-backendsthat work with the changes here inhttomo, andhttomoCI needs to installhttomo-backendsfrom PyPI.Checklist