Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box_size_um cannot be passed from GDA in hyperion requests #762

Closed
rtuck99 opened this issue Jan 24, 2025 · 1 comment
Closed

box_size_um cannot be passed from GDA in hyperion requests #762

rtuck99 opened this issue Jan 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Jan 24, 2025

Currently the box_size_um parameter cannot be specified in request parameters to hyperion because it is only present in the GridScanWithEdgeDetect class which is not inherited by anything in the request parameter class hierarchy.

see e.g.

[31m[E 250122 13:57:00.429 __main__:267] ['Traceback (most recent call last):\n', '  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.3/mx-bluesky/src/mx_bluesky/hyperion/__main__.py", line 241, in compose_start_args\n    raise ValueError(f"Extra fields not allowed {parameters.model_extra}")\n', "ValueError: Extra fields not allowed {'box_size_um': 20.0}\n", '\nThe above exception was the direct cause of the following exception:\n\n', 'Traceback (most recent call last):\n', '  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.3/mx-bluesky/src/mx_bluesky/hyperion/__main__.py", line 259, in put\n    plan, params, plan_name, callback_type = compose_start_args(\n                                             ^^^^^^^^^^^^^^^^^^^\n', '  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.3/mx-bluesky/src/mx_bluesky/hyperion/__main__.py", line 243, in compose_start_args\n    raise ValueError(\n', 'ValueError: Supplied parameters don\'t match the plan for this endpoint b\'{"storage_directory": "/dls/i03/data/2025/cm40607-1/xraycentring/TestThaumatin/thau_4", "sample_puck": "1", "exposure_time_s": 0.004, "file_name": "thau_4", "sample_id": 6197098, "box_size_um": 20.0, "omega_start_deg": 0, "sample_pin": "4", "use_roi_mode": true, "chi_start_deg": 0.0, "features": {"compare_cpu_and_gpu_zocalo": true}, "detector_distance_mm": 196.6079939921457, "demand_energy_ev": null, "visit": "cm40607-1", "transmission_frac": 1.0, "parameter_model_version": "5.0.0"}\', for plan robot_load_then_centre\n']�[0m

Acceptance Criteria

  • Specific criteria that will be used to judge if the issue is fixed
@DominicOram
Copy link
Contributor

Fixed by #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants