Fix for box_size_um not included in robot_load_then_centre_plan. #763
Conversation
Additional tests for request parameter decode and pass-through
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
- Coverage 87.00% 87.00% -0.01%
==========================================
Files 101 101
Lines 6966 6965 -1
==========================================
- Hits 6061 6060 -1
Misses 905 905
|
There was a problem hiding this comment.
Great, thanks. Just some minor nit comments. I made #768 to address them but you can just close that off if you like
| with patch( | ||
| "mx_bluesky.hyperion.experiment_plans.pin_centre_then_xray_centre_plan.detect_grid_and_do_gridscan" | ||
| ) as mock_detect_grid: |
There was a problem hiding this comment.
Nit: I normally prefer using the patch decorator, unless there's a specific reason you can't (which I don't think there is in this case?) as it leads to less indentation and I feel like keeps the test tidier but I get that's probably personal preference
| "tests/test_data/parameter_json_files/good_test_grid_with_edge_detect_parameters" | ||
| ".json", |
There was a problem hiding this comment.
Nit: Having the .json on a separate line made me think it was a new arg at first glance. I think it's more readable together, even if it is longer than the line length
Fixes
Depends on
box_size_umshould no longer be rejected when specified in robot_load_then_centre